bitua/zigfetch
8
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

ci: build releases on the dedicated runner pool #1

Merged
marco merged 1 commits from ci/dedicated-runners into main 2026-09-12 00:13:29 +00:00
Conversation 1 Commits 1 Files Changed 1 +1 -1
marco commented 2026-09-11 23:16:38 +00:00
Owner
Copy Link

Contexto

El release de zigfetch pedía ubuntu-latest, que hoy atienden los runners de sitio de infra01. Es uno de los consumidores que faltaban en la migración de bitua/network#243.

Cambio

runs-on: [x86_64, debian]. El job publica un asset zigfetch-x86_64-linux.zip, así que queda pineado a amd64 en vez del pool mixto.

La imagen runner-image:trixie trae sudo, apt, zip, curl, jq y node 24 para las JS actions (actions/checkout@v4, mlugg/setup-zig@v2); el step de libpci-dev sigue instalándose por apt como antes. No cambian versiones ni el flujo de release.

Validación

YAML validado localmente. El workflow sólo dispara en tags v*, así que la prueba real llega con el próximo release; no se creó un tag de prueba para forzarla.

## Contexto El release de zigfetch pedía `ubuntu-latest`, que hoy atienden los runners de sitio de infra01. Es uno de los consumidores que faltaban en la migración de bitua/network#243. ## Cambio `runs-on: [x86_64, debian]`. El job publica un asset `zigfetch-x86_64-linux.zip`, así que queda pineado a amd64 en vez del pool mixto. La imagen `runner-image:trixie` trae sudo, apt, zip, curl, jq y node 24 para las JS actions (`actions/checkout@v4`, `mlugg/setup-zig@v2`); el step de `libpci-dev` sigue instalándose por apt como antes. No cambian versiones ni el flujo de release. ## Validación YAML validado localmente. El workflow sólo dispara en tags `v*`, así que la prueba real llega con el próximo release; no se creó un tag de prueba para forzarla.
marco added 1 commit 2026-09-11 23:16:38 +00:00
ci: build releases on the dedicated runner pool
All checks were successful
Botua Minimal, correct runner-label migration; approved with minor validation/glibc notes.
69ecd9829d 
El job pedía `ubuntu-latest`, atendido por los runners de sitio de infra01. Publica un asset amd64, así que queda en `[x86_64, debian]`. Refs bitua/network#243.
botua-bot commented 2026-09-11 23:16:41 +00:00
Owner
Copy Link

✅ Botua — Approved

Summary

This PR migrates the zigfetch release workflow off ubuntu-latest and onto the dedicated self-hosted runner pool by changing a single line in .gitea/workflows/release.yml:13 to runs-on: [x86_64, debian]. The change is small, well-scoped, and consistent with the broader runner migration (the sibling bitua/snitch release workflow uses the exact same label set). Since the job publishes a native zigfetch-x86_64-linux.zip, pinning to x86_64 is correct and avoids mixing architectures. No versions or release steps change.

Strengths

  • Correct label pinning: the artifact is amd64-only (zigfetch-x86_64-linux.zip), so [x86_64, debian] matches the output instead of relying on a mixed/default pool.
  • Consistency with the rest of the migration (snitch uses the same [x86_64, debian] labels).
  • The step still installs libpci-dev via apt, so the toolchain dependency remains explicit rather than assumed from the image.
  • Scope is tight — no unrelated refactors or version bumps.

Issues

Minor

  • Validation gap — .gitea/workflows/release.yml: the workflow only triggers on v* tags, so the new runner/label combination and the image's tooling assumptions (sudo, zip, curl, jq, node, plus apt access to libpci-dev) will be exercised for the first time during a real release. If any assumption is wrong, the failure lands on the release itself. A dry run (temporary workflow_dispatch or a throwaway pre-release tag) would de-risk this. The author already acknowledged this trade-off, so it is not blocking.
  • glibc floor may shift — .gitea/workflows/release.yml:40: the binary is built with zig build -Doptimize=ReleaseSafe and dynamically links libc/libpci (build.zig:32-35). Moving the build host from Ubuntu to Debian trixie (glibc 2.41) can raise the minimum glibc required by the published binary relative to the previous runner. Worth a quick sanity check that the released artifact still runs on the oldest target distro; likely a non-issue if the fleet is on trixie.

Verdict

No critical or important issues. This is a safe, minimal infrastructure change. Approve, with the two minor notes above as things to keep in mind for the next release.

APPROVED: true

Reviewed by Botua — deepseek/deepseek-v4-flash

<!-- botua --> ## ✅ Botua — Approved ### Summary This PR migrates the `zigfetch` release workflow off `ubuntu-latest` and onto the dedicated self-hosted runner pool by changing a single line in `.gitea/workflows/release.yml:13` to `runs-on: [x86_64, debian]`. The change is small, well-scoped, and consistent with the broader runner migration (the sibling `bitua/snitch` release workflow uses the exact same label set). Since the job publishes a native `zigfetch-x86_64-linux.zip`, pinning to `x86_64` is correct and avoids mixing architectures. No versions or release steps change. ### Strengths - Correct label pinning: the artifact is amd64-only (`zigfetch-x86_64-linux.zip`), so `[x86_64, debian]` matches the output instead of relying on a mixed/default pool. - Consistency with the rest of the migration (`snitch` uses the same `[x86_64, debian]` labels). - The step still installs `libpci-dev` via `apt`, so the toolchain dependency remains explicit rather than assumed from the image. - Scope is tight — no unrelated refactors or version bumps. ### Issues #### Minor - **Validation gap** — `.gitea/workflows/release.yml`: the workflow only triggers on `v*` tags, so the new runner/label combination and the image's tooling assumptions (`sudo`, `zip`, `curl`, `jq`, `node`, plus apt access to `libpci-dev`) will be exercised for the first time during a real release. If any assumption is wrong, the failure lands on the release itself. A dry run (temporary `workflow_dispatch` or a throwaway pre-release tag) would de-risk this. The author already acknowledged this trade-off, so it is not blocking. - **glibc floor may shift** — `.gitea/workflows/release.yml:40`: the binary is built with `zig build -Doptimize=ReleaseSafe` and dynamically links libc/libpci (`build.zig:32-35`). Moving the build host from Ubuntu to Debian trixie (glibc 2.41) can raise the minimum glibc required by the published binary relative to the previous runner. Worth a quick sanity check that the released artifact still runs on the oldest target distro; likely a non-issue if the fleet is on trixie. ### Verdict No critical or important issues. This is a safe, minimal infrastructure change. Approve, with the two minor notes above as things to keep in mind for the next release. APPROVED: true --- *Reviewed by Botua — `deepseek/deepseek-v4-flash`*
marco merged commit 9a82625496 into main 2026-09-12 00:13:29 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agustin alejandro botua botua-bot dennis giorgio lucas marco
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bitua/zigfetch#1
Delete Branch "ci/dedicated-runners"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?